HeartSaVioR commented on a change in pull request #27575: [SPARK-30827][DOCS]
Document direct relationship among configurations in "spark.history.*" namespace
URL: https://github.com/apache/spark/pull/27575#discussion_r379825206
##########
File path: docs/monitoring.md
##########
@@ -159,22 +159,22 @@ Security options for the Spark History Server are
covered more detail in the
<td>false</td>
<td>
Indicates whether the history server should use kerberos to login. This
is required
- if the history server is accessing HDFS files on a secure Hadoop
cluster. If this is
- true, it uses the configs <code>spark.history.kerberos.principal</code>
and
- <code>spark.history.kerberos.keytab</code>.
+ if the history server is accessing HDFS files on a secure Hadoop cluster.
</td>
</tr>
<tr>
<td>spark.history.kerberos.principal</td>
<td>(none)</td>
<td>
+ Precondition: <code>spark.history.kerberos.enabled=true</code><br/><br/>
Review comment:
I'm seeing different styles in current codebase - I've sought three cases
and styles are all different:
> spark.dynamicAllocation
if dynamic allocation is enabled (either placed on the first or the last)
> `spark.task.reaper.*`
When <code>spark.task.reaper.enabled = true</code>
> spark.sql.adaptive.shuffle.reducePostShufflePartitions.enabled
When true and '${ADAPTIVE_EXECUTION_ENABLED.key}' is enabled,
Common part across these finding is that we prefer putting it to the first
part so that end user can indicate it earlier instead of reading all
description and realized it later.
Looks like second and third style look similar, I'll take these style and
update here.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
