xuanyuanking commented on a change in pull request #27579: [SPARK-30829][SQL]
Define LegacyBehaviorPolicy enumeration as the common value for result change
configs
URL: https://github.com/apache/spark/pull/27579#discussion_r379385520
##########
File path:
sql/catalyst/src/main/scala/org/apache/spark/sql/internal/SQLConf.scala
##########
@@ -2106,13 +2106,19 @@ object SQLConf {
.booleanConf
.createWithDefault(false)
- val LEGACY_CTE_PRECEDENCE_ENABLED =
buildConf("spark.sql.legacy.ctePrecedence.enabled")
+ object LegacyBehaviorPolicy extends Enumeration {
+ val EXCEPTION, LEGACY, NEW_BEHAVIOR = Value
Review comment:
Thanks for the advice @viirya. Yes, both `INNER_FIRST` and
`INNER_PRECEDENCE` are more accurate in this PR, but I also want to make this
enum as a common config value, which can be reused in other similar issues.
WDYT?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
