cloud-fan commented on a change in pull request #27579: [SPARK-30829][SQL]
Define LegacyBehaviorPolicy enumeration as the common value for result change
configs
URL: https://github.com/apache/spark/pull/27579#discussion_r379391745
##########
File path:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/CTESubstitution.scala
##########
@@ -54,8 +54,8 @@ object CTESubstitution extends Rule[LogicalPlan] {
case (cteName, _) =>
if (cteNames.contains(cteName)) {
throw new AnalysisException(s"Name $cteName is ambiguous in
nested CTE. " +
- s"Please set ${LEGACY_CTE_PRECEDENCE_ENABLED.key} to false so
that name defined " +
- "in inner CTE takes precedence. See more details in
SPARK-28228.")
+ s"Please set ${LEGACY_CTE_PRECEDENCE_POLICY.key} to
NEW_BEHAVIOR so that name " +
+ "defined in inner CTE takes precedence. See more details in
SPARK-28228.")
Review comment:
since it's enum now, maybe also explain what will happen if set it to legacy.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
