gengliangwang commented on a change in pull request #27495: [SPARK-28880][SQL]
Support ANSI nested bracketed comments
URL: https://github.com/apache/spark/pull/27495#discussion_r380404092
##########
File path:
sql/catalyst/src/main/antlr4/org/apache/spark/sql/catalyst/parser/SqlBase.g4
##########
@@ -1801,7 +1801,7 @@ BRACKETED_EMPTY_COMMENT
;
BRACKETED_COMMENT
- : '/*' ~[+] .*? '*/' -> channel(HIDDEN)
+ : '/*' ~[+] (BRACKETED_COMMENT|.)*? '*/' -> channel(HIDDEN)
Review comment:
@beliefer my point of the case
```
/*/**/*/
```
is not about empty comment. It is about another `/*` after `/*`.
We can change the case to
```
/*/*foo*/*/
```
The latest fix will still failed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
