gengliangwang commented on a change in pull request #27495: [SPARK-28880][SQL]
Support ANSI nested bracketed comments
URL: https://github.com/apache/spark/pull/27495#discussion_r381050531
##########
File path:
sql/catalyst/src/main/antlr4/org/apache/spark/sql/catalyst/parser/SqlBase.g4
##########
@@ -1797,11 +1797,11 @@ SIMPLE_COMMENT
;
BRACKETED_EMPTY_COMMENT
- : '/**/' -> channel(HIDDEN)
+ : '/*' BRACKETED_EMPTY_COMMENT* '*/' -> channel(HIDDEN)
;
BRACKETED_COMMENT
- : '/*' ~[+] .*? '*/' -> channel(HIDDEN)
+ : '/*' (BRACKETED_COMMENT .*? | ~[+] (BRACKETED_COMMENT|.)*?)*? '*/' ->
channel(HIDDEN)
Review comment:
Ah, I see.
I am not sure about the latest code now. I think it is more reasonable to
follow @cloud-fan 's advice.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
