cloud-fan commented on a change in pull request #27560: [SPARK-30809][SQL]
Review and fix issues in SQL API docs
URL: https://github.com/apache/spark/pull/27560#discussion_r381889311
##########
File path:
sql/catalyst/src/main/scala/org/apache/spark/sql/types/DataType.scala
##########
@@ -488,6 +488,8 @@ object DataType {
/**
* Jackson serializer for [[DataType]]. Internally this delegates to json4s
based serialization.
+ *
+ * @since 3.0.0
*/
class DataTypeJsonSerializer extends JsonSerializer[DataType] {
Review comment:
these 2 were added in
https://github.com/apache/spark/pull/26127/files#diff-df78a74ef92d9b8fb4ac142ff9a62464R490
I don't think we want to publish them. Can we move them to a private
package? like `xxx.catalyst.utils`
also cc @hvanhovell
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
