cloud-fan commented on a change in pull request #27560: [SPARK-30809][SQL]
Review and fix issues in SQL API docs
URL: https://github.com/apache/spark/pull/27560#discussion_r381890133
##########
File path:
sql/catalyst/src/main/scala/org/apache/spark/sql/types/numerics.scala
##########
@@ -22,7 +22,7 @@ import scala.math.Ordering
import org.apache.spark.sql.types.Decimal.DecimalIsConflicted
-object ByteExactNumeric extends ByteIsIntegral with Ordering.ByteOrdering {
+private[sql] object ByteExactNumeric extends ByteIsIntegral with
Ordering.ByteOrdering {
Review comment:
I'm OK with it. But we should also move this file to a private package.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
