HyukjinKwon commented on a change in pull request #27653: [MINOR][SQL] Add a
comment for `removedSQLConfigs`
URL: https://github.com/apache/spark/pull/27653#discussion_r382357860
##########
File path:
sql/catalyst/src/main/scala/org/apache/spark/sql/internal/SQLConf.scala
##########
@@ -2254,6 +2254,13 @@ object SQLConf {
* The map contains info about removed SQL configs. Keys are SQL config
names,
* map values contain extra information like the version in which the config
was removed,
* config's default value and a comment.
+ *
+ * Removed SQL config should be added to the map iff its non-default value
changed
Review comment:
Another suggestion is like:
> Adds removed SQL configurations here only when the configuration affects
behaviours. For example, `spark.sql.variable.substitute.depth` configuration
was not added as it virtually became no-op later. By this, it makes migrations
to new Spark versions painless.
I think we can write this simpler.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
