cloud-fan commented on a change in pull request #27653: [MINOR][SQL] Add a
comment for `removedSQLConfigs`
URL: https://github.com/apache/spark/pull/27653#discussion_r382410179
##########
File path:
sql/catalyst/src/main/scala/org/apache/spark/sql/internal/SQLConf.scala
##########
@@ -2254,6 +2254,13 @@ object SQLConf {
* The map contains info about removed SQL configs. Keys are SQL config
names,
* map values contain extra information like the version in which the config
was removed,
* config's default value and a comment.
+ *
+ * Removed SQL config should be added to the map iff its non-default value
changed
+ * the behavior. Any removed config of `removedSQLConfigs` which set to a
non-default
+ * value raises an exception propagated to user's app. For example, the SQL
config
+ * `spark.sql.variable.substitute.depth` was deprecated since Spark 2.1 and
not
+ * used in Spark 2.4, so, it should not be placed here because the config
Review comment:
actually, we should've put in it remove configs in 2.4...
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
