Github user zsxwing commented on a diff in the pull request:

    https://github.com/apache/spark/pull/516#discussion_r11936165
  
    --- Diff: 
core/src/test/scala/org/apache/spark/scheduler/SparkListenerSuite.scala ---
    @@ -177,6 +177,7 @@ class SparkListenerSuite extends FunSuite with 
LocalSparkContext with ShouldMatc
         listener.stageInfos.clear()
     
         rdd3.count()
    +    assert(sc.listenerBus.waitUntilEmpty(WAIT_TIMEOUT_MILLIS))
    --- End diff --
    
    Just realize that `waitUntilEmpty` is not enough. In `waitUntilEmpty`, it 
only checks `eventQueue.isEmpty`. But when `eventQueue.isEmpty` is true, there 
is still a chance that listeners do not finish their jobs or the memory is not 
synchronized.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

Reply via email to