Github user andrewor14 commented on a diff in the pull request:
https://github.com/apache/spark/pull/516#discussion_r11936322
--- Diff:
core/src/test/scala/org/apache/spark/scheduler/SparkListenerSuite.scala ---
@@ -177,6 +177,7 @@ class SparkListenerSuite extends FunSuite with
LocalSparkContext with ShouldMatc
listener.stageInfos.clear()
rdd3.count()
+ assert(sc.listenerBus.waitUntilEmpty(WAIT_TIMEOUT_MILLIS))
--- End diff --
Good catch. A solution is to have `eventQueue` peek instead of take in
https://github.com/apache/spark/blob/master/core/src/main/scala/org/apache/spark/scheduler/LiveListenerBus.scala#L43,
such that we remove the event from the queue only after all listeners have
finished processing it.
Many other places have long been relying on `waitUntilEmpty` even before
this PR. It makes me wonder how likely this race condition actually causes a
test failure...
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
