tgravescs commented on a change in pull request #27693: [SPARK-30947][CORE] Log
better message when accelerate resource is empty
URL: https://github.com/apache/spark/pull/27693#discussion_r384819490
##########
File path: core/src/main/scala/org/apache/spark/resource/ResourceProfile.scala
##########
@@ -194,7 +194,8 @@ class ResourceProfile(
throw new SparkException("No executor resource configs were not
specified for the " +
s"following task configs: ${taskResourcesToCheck.keys.mkString(",")}")
}
- logInfo(s"Limiting resource is $limitingResource at $taskLimit tasks per
executor")
+ val limiting = if (taskLimit == -1) "None" else limitingResource
+ logInfo(s"Limiting resource is $limiting at $taskLimit tasks per executor")
Review comment:
yes good idea, if taskLimiit == -1 then just set it to CPU because there
weren't any other custom resources.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
