yma11 commented on a change in pull request #27546: [SPARK-30773][ML]Support 
NativeBlas for level-1 routines
URL: https://github.com/apache/spark/pull/27546#discussion_r384959562
 
 

 ##########
 File path: mllib-local/src/main/scala/org/apache/spark/ml/linalg/BLAS.scala
 ##########
 @@ -27,15 +27,35 @@ private[spark] object BLAS extends Serializable {
 
   @transient private var _f2jBLAS: NetlibBLAS = _
   @transient private var _nativeBLAS: NetlibBLAS = _
+  @transient private val vectorSizeThreshold: Int = 256
 
-  // For level-1 routines, we use Java implementation.
+  // For level-3 routines, we use the native BLAS.
+  // if native BLAS is not properly configured in system, will automatically 
fallback to f2jBLAS
+  private[ml] def nativeBLAS: NetlibBLAS = {
 
 Review comment:
   I add a note in ml-guide to highlight nativeBLAS usage depends on proper 
configuration in system otherwise will fallback to java implementation.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to