cloud-fan commented on a change in pull request #27537:
[SPARK-30668][SQL][FOLLOWUP] Raise exception instead of silent change for new
TimestampFormatter
URL: https://github.com/apache/spark/pull/27537#discussion_r385173322
##########
File path:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/util/DateFormatter.scala
##########
@@ -124,4 +135,24 @@ object DateFormatter {
def apply(zoneId: ZoneId): DateFormatter = {
getFormatter(None, zoneId)
}
+
+ def hasDiffResult(s: String, format: String, zoneId: ZoneId): Boolean = {
+ // Only check whether we will get different results between legacy format
and new format, while
+ // legacy time parser policy set to EXCEPTION. For legacy parser,
DateTimeParseException will
+ // not be thrown. On the contrary, if the legacy policy set to CORRECTED,
+ // DateTimeParseException will address by the caller side.
+ if (LegacyBehaviorPolicy.withName(
+ SQLConf.get.getConf(SQLConf.LEGACY_TIME_PARSER_POLICY)) == EXCEPTION) {
+ val formatter = new LegacySimpleTimestampFormatter(
+ format, zoneId, defaultLocale, lenient = false)
Review comment:
different places can create different legacy formatter. It's better to
always create the legacy formatter, and the new formatter just carry the
instance of legacy formatter.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
