cloud-fan commented on a change in pull request #27537:
[SPARK-30668][SQL][FOLLOWUP] Raise exception instead of silent change for new
TimestampFormatter
URL: https://github.com/apache/spark/pull/27537#discussion_r386424103
##########
File path:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/util/DateTimeFormatterHelper.scala
##########
@@ -57,6 +61,29 @@ trait DateTimeFormatterHelper {
}
formatter
}
+
+ // When legacy time parser policy set to EXCEPTION, check whether we will
get different results
+ // between legacy format and new format. For legacy parser,
DateTimeParseException will not be
+ // thrown. On the contrary, if the legacy policy set to CORRECTED,
DateTimeParseException will
+ // address by the caller side.
+ protected def checkDiffResult[T](
+ s: String, legacyParseFunc: String => T): PartialFunction[Throwable, T] = {
+ case e: DateTimeParseException if LegacyBehaviorPolicy.withName(
+ SQLConf.get.getConf(SQLConf.LEGACY_TIME_PARSER_POLICY)) == EXCEPTION =>
+ val res = try {
+ Some(legacyParseFunc(s))
+ } catch {
+ case _: Throwable => None
+ }
+ if (res.nonEmpty) {
+ throw new SparkUpgradeException("3.0", e.getMessage + ", set " +
Review comment:
The standard way is to set the original exception as `cause`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
