srowen commented on a change in pull request #27546: [SPARK-30773][ML]Support
NativeBlas for level-1 routines
URL: https://github.com/apache/spark/pull/27546#discussion_r386032347
##########
File path: mllib-local/src/main/scala/org/apache/spark/ml/linalg/BLAS.scala
##########
@@ -20,22 +20,42 @@ package org.apache.spark.ml.linalg
import com.github.fommil.netlib.{BLAS => NetlibBLAS, F2jBLAS}
import com.github.fommil.netlib.BLAS.{getInstance => NativeBLAS}
+import org.apache.spark.SparkConf
+import org.apache.spark.internal.config.NATIVE_L1_THRESHOLD
+
/**
* BLAS routines for MLlib's vectors and matrices.
*/
private[spark] object BLAS extends Serializable {
@transient private var _f2jBLAS: NetlibBLAS = _
@transient private var _nativeBLAS: NetlibBLAS = _
+ private val nativeL1Threshold =
+ new SparkConf().getInt(NATIVE_L1_THRESHOLD.key, 256)
Review comment:
You should be able to access the value from the ConfigEntry directly, and
not repeat the default
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
