srowen commented on a change in pull request #27546: [SPARK-30773][ML]Support 
NativeBlas for level-1 routines
URL: https://github.com/apache/spark/pull/27546#discussion_r386789749
 
 

 ##########
 File path: mllib-local/pom.xml
 ##########
 @@ -61,13 +61,17 @@
       This spark-tags test-dep is needed even though it isn't used in this 
module, otherwise testing-cmds that exclude
       them will yield errors.
     -->
+    <dependency>
 
 Review comment:
   Ah, OK that is not even available, right. I think I'd just make it a 
hard-coded constant then. I don't think we can reasonably expect people to find 
and discover and env variable that probably isn't that meaningful to tune. Just 
set it conservatively. 512?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to