Ngone51 commented on a change in pull request #27752: [SPARK-30999][SQL] Don't
cancel a QueryStageExec which failed before call doMaterialize
URL: https://github.com/apache/spark/pull/27752#discussion_r386461259
##########
File path:
sql/core/src/main/scala/org/apache/spark/sql/execution/adaptive/AdaptiveSparkPlanExec.scala
##########
@@ -176,7 +179,9 @@ case class AdaptiveSparkPlanExec(
}
}(AdaptiveSparkPlanExec.executionContext)
} catch {
- case e: Throwable => events.offer(StageFailure(stage, e))
+ case e: Throwable =>
+ earlyFailedStage = Some(stage.id)
Review comment:
We'll stop materializing following stages once we catch exception here and
call `cleanUpAndThrowException` soon. So I think it may doesn't make big
difference if you mean to call it earlier.
Also, we need to do extra stuff for the exception below.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
