cloud-fan commented on a change in pull request #27752: [SPARK-30999][SQL] 
Don't cancel a QueryStageExec which failed before call doMaterialize 
URL: https://github.com/apache/spark/pull/27752#discussion_r386468246
 
 

 ##########
 File path: 
sql/core/src/main/scala/org/apache/spark/sql/execution/adaptive/AdaptiveSparkPlanExec.scala
 ##########
 @@ -176,7 +179,9 @@ case class AdaptiveSparkPlanExec(
                 }
               }(AdaptiveSparkPlanExec.executionContext)
             } catch {
-              case e: Throwable => events.offer(StageFailure(stage, e))
+              case e: Throwable =>
+                earlyFailedStage = Some(stage.id)
 
 Review comment:
   Does it still count as `Failed to materialize query stage` when initializing 
lazy val fails? If it counts then it seems better to send an event here.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to