maryannxue commented on a change in pull request #27752: [SPARK-30999][SQL]
Don't cancel a QueryStageExec which failed before call doMaterialize
URL: https://github.com/apache/spark/pull/27752#discussion_r386554919
##########
File path:
sql/core/src/main/scala/org/apache/spark/sql/execution/adaptive/AdaptiveSparkPlanExec.scala
##########
@@ -176,7 +179,9 @@ case class AdaptiveSparkPlanExec(
}
}(AdaptiveSparkPlanExec.executionContext)
} catch {
- case e: Throwable => events.offer(StageFailure(stage, e))
+ case e: Throwable =>
+ earlyFailedStage = Some(stage.id)
Review comment:
What extra stuff do we need to do? The event queue does not matter once you
catch an active exception.
My idea was in the catch block, we just do:
```
errors.prepend(new SparkException(...)) // this should be the primary
exception
cleanUpAndThrowException(errors, Some(stage.id))
```
And we can probably make this exception message slightly different from
other stage failure messages.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
