maryannxue commented on a change in pull request #27752: [SPARK-30999][SQL]
Don't cancel a QueryStageExec which failed before call doMaterialize
URL: https://github.com/apache/spark/pull/27752#discussion_r387087525
##########
File path:
sql/core/src/main/scala/org/apache/spark/sql/execution/adaptive/AdaptiveSparkPlanExec.scala
##########
@@ -176,7 +176,10 @@ case class AdaptiveSparkPlanExec(
}
}(AdaptiveSparkPlanExec.executionContext)
} catch {
- case e: Throwable => events.offer(StageFailure(stage, e))
+ case e: Throwable =>
+ errors.prepend(
+ new SparkException(s"Early failed query stage found:
${stage.treeString}", e))
+ cleanUpAndThrowException(errors, Some(stage.id))
Review comment:
You call `cleanUpAndThrowException` right after, so any error in this round
has not been added through "StageFailure" message processing yet. And there
cannot be any errors from previous rounds, otherwise it would have thrown and
exited already.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
