Github user pwendell commented on a diff in the pull request:

    https://github.com/apache/spark/pull/4799#discussion_r25573606
  
    --- Diff: core/src/main/scala/org/apache/spark/executor/Executor.scala ---
    @@ -92,6 +92,16 @@ private[spark] class Executor(
       private val executorActor = env.actorSystem.actorOf(
         Props(new ExecutorActor(executorId)), "ExecutorActor")
     
    +  // Whether to load classes in user jars before those in Spark jars
    +  private val userClassPathFirst: Boolean = {
    +    val oldKey = "spark.files.userClassPathFirst"
    +    val newKey = "spark.executor.userClassPathFirst"
    +    if (conf.contains(oldKey)) {
    +      logWarning(s"$oldKey is deprecated. Please use $newKey instead.")
    --- End diff --
    
    This will log it on the executors, which seems weird since all other 
configuration warnings are logged at the driver or submission client. Can we 
just log this warning on the driver side? Or just don't log a deprecation 
warning always?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to