Github user vanzin commented on a diff in the pull request:

    https://github.com/apache/spark/pull/4799#discussion_r25643128
  
    --- Diff: core/src/main/scala/org/apache/spark/SparkConf.scala ---
    @@ -343,6 +343,13 @@ class SparkConf(loadDefaults: Boolean) extends 
Cloneable with Logging {
             }
           }
         }
    +
    +    // Warn against the use of deprecated configs
    +    deprecatedConfigs.values.foreach { dc =>
    --- End diff --
    
    Since you're doing this only once during the app's lifetime (this method is 
only called from SparkContext AFAICT), you could simplify the code that tracks 
whether warns have been printed in `DeprecatedConfig`. But ok to not do it if 
you want to limit the scope of the change.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to