tgravescs commented on a change in pull request #27636:
[SPARK-30873][CORE][YARN]Handling Node Decommissioning for Yarn cluster manger
in Spark
URL: https://github.com/apache/spark/pull/27636#discussion_r389679606
##########
File path: core/src/main/scala/org/apache/spark/internal/config/package.scala
##########
@@ -1542,4 +1542,55 @@ package object config {
.bytesConf(ByteUnit.BYTE)
.createOptional
+ private[spark] val GRACEFUL_DECOMMISSION_ENABLE =
+ ConfigBuilder("spark.graceful.decommission.enable")
+ .doc("Whether to enable the node graceful decommissioning handling")
+ .booleanConf
+ .createWithDefault(false)
+
+ private[spark] val GRACEFUL_DECOMMISSION_FETCHFAILED_IGNORE_THRESHOLD =
+ ConfigBuilder("spark.graceful.decommission.fetchfailed.ignore.threshold")
+ .doc("Threshold of number of times fetchfailed ignored due to node" +
+ " decommission.This is configurable as per the need of the user and" +
+ " depending upon type of the cloud. If we keep this a large value and
" +
+ " there is continuous decommission of nodes, in those scenarios stage"
+
+ " will never abort and keeps on retrying in an unbounded manner.")
+ .intConf
+ .createWithDefault(8)
+
+ private[spark] val GRACEFUL_DECOMMISSION_EXECUTOR_LEASETIME_PCT =
+ ConfigBuilder("spark.graceful.decommission.executor.leasetimePct")
+ .doc("Percentage of time to expiry after which executors are killed " +
+ "(if enabled) on the node. Value ranges between (0-100)")
+ .intConf
+ .checkValue(v => v >= 0 && v < 100, "The percentage should be positive.")
+ .createWithDefault(50) // Pulled out of thin air.
+
+ private[spark] val GRACEFUL_DECOMMISSION_SHUFFLEDATA_LEASETIME_PCT =
+ ConfigBuilder("spark.graceful.decommission.shuffedata.leasetimePct")
+ .doc("Percentage of time to expiry after which shuffle data " +
Review comment:
similar here we should describe what this is a percentage of.
I assume this has to be >= so that executors don't write more shuffle data.
It might be better just to fail if this is incorrectly set assuming we can
check it early enough. I guess I'll see more code later
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
