tgravescs commented on a change in pull request #27636:
[SPARK-30873][CORE][YARN]Handling Node Decommissioning for Yarn cluster manger
in Spark
URL: https://github.com/apache/spark/pull/27636#discussion_r389681241
##########
File path: core/src/main/scala/org/apache/spark/internal/config/package.scala
##########
@@ -1542,4 +1542,46 @@ package object config {
.bytesConf(ByteUnit.BYTE)
.createOptional
+ private[spark] val GRACEFUL_DECOMMISSION_ENABLE =
+ ConfigBuilder("spark.graceful.decommission.enable")
+ .doc("Whether to enable the node graceful decommissioning handling")
+ .booleanConf
+ .createWithDefault(false)
+
+ private[spark] val GRACEFUL_DECOMMISSION_FETCHFAILED_IGNORE_THRESHOLD =
+ ConfigBuilder("spark.graceful.decommission.fetchfailed.ignore.threshold")
+ .doc("Threshold of number of times fetchfailed ignored due to node
decommission")
+ .intConf
+ .createWithDefault(8)
+
+ private[spark] val GRACEFUL_DECOMMISSION_EXECUTOR_LEASETIME_PCT =
+ ConfigBuilder("spark.graceful.decommission.executor.leasetimePct")
+ .doc("Percentage of time to expiry after which executors are killed " +
+ "(if enabled) on the node. Value ranges between (0-100)")
+ .intConf
+ .checkValue(v => v >= 0 && v < 100, "The percentage should be positive.")
+ .createWithDefault(50) // Pulled out of thin air.
+
+ private[spark] val GRACEFUL_DECOMMISSION_SHUFFLEDATA_LEASETIME_PCT =
+ ConfigBuilder("spark.graceful.decommission.shuffedata.leasetimePct")
+ .doc("Percentage of time to expiry after which shuffle data " +
+ "cleaned up (if enabled) on the node. Value ranges between (0-100)")
+ .intConf
+ .checkValue(v => v >= 0 && v < 100, "The percentage should be positive.")
+ .createWithDefault(90) // Pulled out of thin air.
+
+ private[spark] val GRACEFUL_DECOMMISSION_MIN_TERMINATION_TIME_IN_SEC =
Review comment:
haven't looked at design doc, but same question - I only see this used in
test? If that is the case I think we atleast need a comment about it. I think
I have same concern here as above, I don't really know what this config means
as well. what is the min time to termination?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
