Github user rxin commented on a diff in the pull request:
https://github.com/apache/spark/pull/4850#discussion_r25620901
--- Diff: core/src/main/scala/org/apache/spark/executor/Executor.scala ---
@@ -380,61 +388,69 @@ private[spark] class Executor(
}
}
- def startDriverHeartbeater() {
- val interval = conf.getInt("spark.executor.heartbeatInterval", 10000)
+ /** Reports heartbeat and metrics for active tasks to the driver. */
+ private def reportHeartBeat(): Unit = {
val timeout = AkkaUtils.lookupTimeout(conf)
val retryAttempts = AkkaUtils.numRetries(conf)
val retryIntervalMs = AkkaUtils.retryWaitMs(conf)
val heartbeatReceiverRef =
AkkaUtils.makeDriverRef("HeartbeatReceiver", conf, env.actorSystem)
--- End diff --
nah they are better to be taken out of this function. going to put it in
the class itself as fields. once we have our own rpc interface, we can delete
this.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
