Github user vanzin commented on a diff in the pull request:
https://github.com/apache/spark/pull/4821#discussion_r25641491
--- Diff:
core/src/test/scala/org/apache/spark/deploy/history/FsHistoryProviderSuite.scala
---
@@ -89,16 +105,18 @@ class FsHistoryProviderSuite extends FunSuite with
BeforeAndAfter with Matchers
val list = provider.getListing().toSeq
list should not be (null)
- list.size should be (4)
- list.count(e => e.completed) should be (2)
+ list.size should be (5)
+ list.count(_.completed) should be (3)
list(0) should be (ApplicationHistoryInfo(newAppComplete.getName(),
"new-app-complete", 1L, 4L,
newAppComplete.lastModified(), "test", true))
- list(1) should be (ApplicationHistoryInfo(oldAppComplete.getName(),
"old-app-complete", 2L, 3L,
+ list(1) should be
(ApplicationHistoryInfo(newAppCompressedComplete.getName(),
--- End diff --
I think your problem is that entires `1` and `2` have both the same start
and end time, so their sort order is non-deterministic. Also,
`newAppCompressedComplete` has end time `4` in the code a few lines above. So
it seems your test code has a couple of issues, this is not really flakiness.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
