Github user pwendell commented on a diff in the pull request: https://github.com/apache/spark/pull/4821#discussion_r25648384 --- Diff: core/src/main/scala/org/apache/spark/util/JsonProtocol.scala --- @@ -574,6 +583,11 @@ private[spark] object JsonProtocol { SparkListenerExecutorRemoved(time, executorId, reason) } + def logStartFromJson(json: JValue): SparkListenerLogStart = { + val version = (json \ "Spark Version").extract[String] --- End diff -- minor - but maybe call this `sparkVersion` so it's clear that this isn't a version for the logging format (since that doesn't have its own versioning).
--- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org