Github user logc commented on the pull request:
https://github.com/apache/spark/pull/134#issuecomment-41266700
I just corrected the style comments, except for one where I would like
clarification on your style standard.
I understand that the Spark project uses mainly SBT for construction,
installation and testing. Probably you do not want to mix in another build
system for the Python part (in the sense of managing dependencies). However,
please make the project aware that the second mechanism I propose --defining a
`setup.py`-- works without the user needing anything except a Python
interpreter (which is anyway needed just to launch the script).
And let me also mention that I reviewed the Travis error on my previous
commit, and it seems unrelated to my changes: an SBT test for `BagelSuite`,
whatever that is, does *not* halt after a `large number of iterations`.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
