Github user vanzin commented on a diff in the pull request:
https://github.com/apache/spark/pull/4845#discussion_r25652199
--- Diff:
core/src/main/scala/org/apache/spark/deploy/history/FsHistoryProvider.scala ---
@@ -208,10 +208,17 @@ private[history] class FsHistoryProvider(conf:
SparkConf) extends ApplicationHis
if (!logInfos.isEmpty) {
val newApps = new mutable.LinkedHashMap[String,
FsApplicationHistoryInfo]()
def addIfAbsent(info: FsApplicationHistoryInfo) = {
- if (!newApps.contains(info.id) ||
-
newApps(info.id).logPath.endsWith(EventLoggingListener.IN_PROGRESS) &&
+ val key =
+ if (info.appAttemptId.equals("")) {
+ info.id
+ } else {
+ info.id + "_" + info.appAttemptId
+ }
+
+ if (!newApps.contains(key) ||
--- End diff --
Feels like you should add parentheses here somewhere to clarify in which
order the conditions should be parsed, since you're mixing `$$` and `||`.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
