Github user vanzin commented on a diff in the pull request:

    https://github.com/apache/spark/pull/4845#discussion_r25652477
  
    --- Diff: 
core/src/main/scala/org/apache/spark/deploy/history/HistoryPage.scala ---
    @@ -113,6 +129,36 @@ private[spark] class HistoryPage(parent: 
HistoryServer) extends WebUIPage("") {
           </div>
         UIUtils.basicSparkPage(content, "History Server")
       }
    +  
    +  private def getApplicationLevelList (appNattemptList: 
Iterable[ApplicationHistoryInfo])  ={
    +    // Create HashMap as per the multiple attempts for one application. 
    +    // If there is no attempt specific stuff, then
    +    // do return false, to indicate the same, so that previous UI gets 
displayed.
    +    var hasAttemptInfo = false
    +    val appToAttemptInfo = new HashMap[String, 
ArrayBuffer[ApplicationHistoryInfo]]
    +    for( appAttempt <- appNattemptList) {
    --- End diff --
    
    All throughout the code: `for (...)`, `if (...)`. Note the placement of the 
space.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to