MaxGekk commented on a change in pull request #27915: [WIP][SPARK-31159][SQL]
Rebase date/timestamp from/to Julian calendar in parquet
URL: https://github.com/apache/spark/pull/27915#discussion_r393091673
##########
File path:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/util/DateTimeUtils.scala
##########
@@ -148,7 +148,9 @@ object DateTimeUtils {
def fromJulianDay(day: Int, nanoseconds: Long): SQLTimestamp = {
// use Long to avoid rounding errors
val seconds = (day - JULIAN_DAY_OF_EPOCH).toLong * SECONDS_PER_DAY
- SECONDS.toMicros(seconds) + NANOSECONDS.toMicros(nanoseconds)
+ val micros = SECONDS.toMicros(seconds) + NANOSECONDS.toMicros(nanoseconds)
+ val rebased = rebaseJulianToGregorianMicros(micros)
Review comment:
@cloud-fan I do believe this is a bug fix. We should rebase independently
from new SQL config `spark.sql.legacy.parquet.rebaseDateTime.enabled` because
days are stored as Julian days in Parquet INT96 timestamps.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
