cloud-fan commented on a change in pull request #27915: [WIP][SPARK-31159][SQL]
Rebase date/timestamp from/to Julian calendar in parquet
URL: https://github.com/apache/spark/pull/27915#discussion_r393162134
##########
File path:
sql/catalyst/src/main/scala/org/apache/spark/sql/internal/SQLConf.scala
##########
@@ -3072,6 +3086,8 @@ class SQLConf extends Serializable with Logging {
def integerGroupingIdEnabled: Boolean =
getConf(SQLConf.LEGACY_INTEGER_GROUPING_ID)
+ def parquetRebaseDateTimeEnabled: Boolean =
getConf(SQLConf.LEGACY_PARQUET_REBASE_DATETIME)
Review comment:
It's not recommended to add a method to read a conf if it's only used once.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
