cloud-fan commented on a change in pull request #27906: [SPARK-31150][SQL]
Parsing seconds fraction with variable length for timestamp
URL: https://github.com/apache/spark/pull/27906#discussion_r392912744
##########
File path:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/util/DateTimeFormatterHelper.scala
##########
@@ -87,7 +92,9 @@ trait DateTimeFormatterHelper {
private object DateTimeFormatterHelper {
val cache = CacheBuilder.newBuilder()
.maximumSize(128)
- .build[(String, Locale), DateTimeFormatter]()
+ .build[(String, Locale, Boolean), DateTimeFormatter]()
+
+ final val extractor = "^([^S]*)(S*)(.*)$".r
Review comment:
One thing I'm worried about is ambiguity. e.g. `ss.SSSyyyy`, how are we
going to parse `11.12020`? I think we can only support var length if the parser
after `SSS` is not number type.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
