yaooqinn commented on a change in pull request #27906: [SPARK-31150][SQL]
Parsing seconds fraction with variable length for timestamp
URL: https://github.com/apache/spark/pull/27906#discussion_r393136288
##########
File path: sql/core/src/test/resources/sql-tests/inputs/datetime.sql
##########
@@ -75,3 +75,28 @@ select date '2001-09-28' - null;
-- subtract dates
select null - date '2019-10-06';
select date '2001-10-01' - date '2001-09-28';
+
+-- variable-length tests
+select to_timestamp(v, 'yyyy-MM-dd HH:mm:ss.SSSSSS[zzz]') from values
+ ('2019-10-06 10:11:12.'),
Review comment:
I guess this is fine even though 2.4 will return `null` with `yyyy-MM-dd
HH:mm:ss.S` but success with `yyyy-MM-dd HH:mm:ss.S`. And also it will fail to
parse when I set `S` to optional, this looks weird to me.
Here the `.` in java 8 time API is JUST a separator, it is not the decimal
point, we can put anything after it, eg. timezone, week, `.` e.t.c.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
