Github user srowen commented on the pull request:
https://github.com/apache/spark/pull/2765#issuecomment-76939929
This is getting better. I am still concerned about the MiMa excludes. There
should be no API changes, so, there should be no excludes. Those are still in
this PR.
The additions to the Scala API are not using optional arguments anymore. I
think it's most natural to create an option depth argument on the most
"complete" version of each API method. It is not necessary in Scala to overload
a method to add an optional argument, and it is not necessary to add this
argument to every version of the method.
That is, I think I would expect to see one, maybe two versions of each
Scala API method add a `depth: Int = 1` parameter, only.
In Java, there are no optional params (even though we're writing in Scala)
but I also believe it is not desirable to overload every single method. The one
with the most args can take the overload.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
