Github user srowen commented on a diff in the pull request:

    https://github.com/apache/spark/pull/2765#discussion_r25684896
  
    --- Diff: 
streaming/src/main/scala/org/apache/spark/streaming/api/java/JavaStreamingContext.scala
 ---
    @@ -293,6 +302,34 @@ class JavaStreamingContext(val ssc: StreamingContext) 
extends Closeable {
        * for new files and reads them using the given key-value types and 
input format.
        * Files must be written to the monitored directory by "moving" them 
from another
        * location within the same file system. File names starting with . are 
ignored.
    +   * It can also monitor files in subdirectories by setting the optional 
`depth`
    +   * parameter to a value greater than 1.
    +   * @param directory HDFS directory to monitor for new file
    +   * @param depth Searching depth of HDFS directory
    +   * @param kClass class of key for reading HDFS file
    +   * @param vClass class of value for reading HDFS file
    +   * @param fClass class of input format for reading HDFS file
    +   * @tparam K Key type for reading HDFS file
    +   * @tparam V Value type for reading HDFS file
    +   * @tparam F Input format for reading HDFS file
    +   */
    +  def fileStream[K, V, F <: NewInputFormat[K, V]](
    +      directory: String,
    +      depth: Int,
    --- End diff --
    
    This looks out of order, but, I question the need for this overload anyway. 
Maybe @tdas has an opinion. I'd like to keep the scope of this change much more 
limited to adding a depth param to 1 version of each method (maybe 2 if it 
really made sense) in each language.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to