yaooqinn commented on a change in pull request #27906: [SPARK-31150][SQL]
Parsing seconds fraction with variable length for timestamp
URL: https://github.com/apache/spark/pull/27906#discussion_r393442908
##########
File path:
sql/catalyst/src/test/scala/org/apache/spark/sql/util/TimestampFormatterSuite.scala
##########
@@ -44,7 +44,8 @@ class TimestampFormatterSuite extends SparkFunSuite with
SQLHelper with Matchers
DateTimeTestUtils.outstandingTimezonesIds.foreach { zoneId =>
val formatter = TimestampFormatter(
"yyyy-MM-dd'T'HH:mm:ss.SSSSSS",
- DateTimeUtils.getZoneId(zoneId))
+ DateTimeUtils.getZoneId(zoneId),
+ needVarLengthSecondFraction = true)
Review comment:
We are not going to use fixed-length formatter for parsing right? So I
guess test that one is not needed anymore. the var-length formatter should work
fine with fixed inputs.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
