yaooqinn commented on a change in pull request #27906: [SPARK-31150][SQL]
Parsing seconds fraction with variable length for timestamp
URL: https://github.com/apache/spark/pull/27906#discussion_r393448225
##########
File path:
sql/catalyst/src/test/scala/org/apache/spark/sql/util/TimestampFormatterSuite.scala
##########
@@ -83,9 +85,9 @@ class TimestampFormatterSuite extends SparkFunSuite with
SQLHelper with Matchers
2177456523456789L,
11858049903010203L).foreach { micros =>
DateTimeTestUtils.outstandingZoneIds.foreach { zoneId =>
- val formatter = TimestampFormatter(pattern, zoneId)
- val timestamp = formatter.format(micros)
- val parsed = formatter.parse(timestamp)
+ val timestamp = TimestampFormatter(pattern, zoneId).format(micros)
+ val parsed = TimestampFormatter(
+ pattern, zoneId, needVarLengthSecondFraction =
true).parse(timestamp)
Review comment:
this change is needed because it is how the actual roundtrip goes no matter
what the input is
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
