Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/4878#discussion_r25714850
--- Diff:
core/src/main/scala/org/apache/spark/deploy/master/FileSystemPersistenceEngine.scala
---
@@ -58,7 +58,7 @@ private[spark] class FileSystemPersistenceEngine(
if (!created) { throw new IllegalStateException("Could not create
file: " + file) }
val serializer = serialization.findSerializerFor(value)
val serialized = serializer.toBinary(value)
- val out = new FileOutputStream(file)
+ val out = new BufferedOutputStream(new FileOutputStream(file))
--- End diff --
Although the buffering in `ExternalSorter` makes sense, I don't know if
this helps anything, since only one write is being done. Another buffer at this
level doesn't do anything but introduce a copy and memory allocation
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
