Github user kayousterhout commented on a diff in the pull request:
https://github.com/apache/spark/pull/4878#discussion_r25821370
--- Diff:
core/src/main/scala/org/apache/spark/shuffle/IndexShuffleBlockManager.scala ---
@@ -106,7 +106,7 @@ class IndexShuffleBlockManager(conf: SparkConf) extends
ShuffleBlockManager {
// find out the consolidated file, then the offset within that from
our index
val indexFile = getIndexFile(blockId.shuffleId, blockId.mapId)
- val in = new DataInputStream(new FileInputStream(indexFile))
+ val in = new DataInputStream(new BufferedInputStream(new
FileInputStream(indexFile)))
--- End diff --
Similar to other comments made by @srowen and @andrewor14, here we're only
reading 2 longs. It doesn't seem like the buffering is necessary?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
