cloud-fan commented on a change in pull request #27942: [SPARK-27946][SQL]
Revise error message for SHOW CREATE TABLE
URL: https://github.com/apache/spark/pull/27942#discussion_r394100083
##########
File path:
sql/core/src/main/scala/org/apache/spark/sql/execution/command/tables.scala
##########
@@ -1110,7 +1110,9 @@ case class ShowCreateTableCommand(table: TableIdentifier)
}
if (tableMetadata.tableType == VIEW) {
- throw new AnalysisException("Hive view isn't supported by SHOW
CREATE TABLE")
+ throw new AnalysisException("Hive view isn't supported by SHOW
CREATE TABLE. " +
Review comment:
IMO there is no such thing called "Hive view". Spark has permanent views
which can be stored in Hive metatore, which is no different from views created
by Hive.
Furthermore, what's the Hive specify syntax for creating views? Maybe we
should support views in both SHOW CREATE TABLE and SHOW CREATE TABLE AS SERDE
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
