viirya commented on a change in pull request #27942: [SPARK-27946][SQL] Revise 
error message for SHOW CREATE TABLE 
URL: https://github.com/apache/spark/pull/27942#discussion_r394104111
 
 

 ##########
 File path: 
sql/core/src/main/scala/org/apache/spark/sql/execution/command/tables.scala
 ##########
 @@ -1110,7 +1110,9 @@ case class ShowCreateTableCommand(table: TableIdentifier)
         }
 
         if (tableMetadata.tableType == VIEW) {
-          throw new AnalysisException("Hive view isn't supported by SHOW 
CREATE TABLE")
+          throw new AnalysisException("Hive view isn't supported by SHOW 
CREATE TABLE. " +
 
 Review comment:
   OK. I get your point now.
   
   This is Hive syntax for creating views:
   
   ```
   CREATE VIEW [IF NOT EXISTS] [db_name.]view_name [(column_name [COMMENT 
column_comment], ...) ]
     [COMMENT view_comment]
     [TBLPROPERTIES (property_name = property_value, ...)]
     AS SELECT ...;
   ```
   
https://cwiki.apache.org/confluence/display/Hive/LanguageManual+DDL#LanguageManualDDL-CreateView
   
   
   This is Spark syntax for creating views:
   ```
   CREATE [OR REPLACE] [[GLOBAL] TEMPORARY] VIEW [IF NOT EXISTS 
[db_name.]view_name
       create_view_clauses
       AS query;
   ```
   
https://spark.apache.org/docs/3.0.0-preview/sql-ref-syntax-ddl-create-view.html
   
   Looks like it is basically the same. I think we could support views in both 
commands as you said.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to