nchammas commented on a change in pull request #27928: [SPARK-31167][BUILD] Refactor how we track Python test/build dependencies URL: https://github.com/apache/spark/pull/27928#discussion_r395198153
########## File path: dev/requirements.txt ########## @@ -1,5 +1,7 @@ -flake8==3.5.0 +pycodestyle==2.5.0 +flake8==3.7.9 jira==1.0.3 PyGithub==1.26.0 Unidecode==0.04.19 -sphinx +sphinx==2.3.1 +numpy==1.18.1 Review comment: Would it help then if we expanded `dev/README.md` to show how to setup a virtual environment? I'm willing to do that. If we don't want to ask devs to use virtual environments at all, then perhaps we need to fork `dev/requirements.txt` and have a version that pins everything, for use in CI and releases, and a version that pins nothing, for use by devs who don't use virtual environments. Another alternative is the compromise currently standing in this PR, with some versions specified as `major.minor.*`. And yet another alternative (which I personally wouldn't favor, but I know it's common) is to Dockerize the whole development environment, but that's a lot of work. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
