nchammas commented on a change in pull request #27928: [SPARK-31167][BUILD] 
Refactor how we track Python test/build dependencies
URL: https://github.com/apache/spark/pull/27928#discussion_r396197611
 
 

 ##########
 File path: dev/requirements.txt
 ##########
 @@ -1,5 +1,10 @@
-flake8==3.5.0
+flake8==3.7.*
 
 Review comment:
   I mentioned it elsewhere but I'll mention it again here: Linters like flake8 
and pycodestyle introduce new checks in minor/feature releases. There is very 
high chance that every new check they introduce will flag new problems and fail 
the build. (In fact, we saw exactly that behavior with pydocstyle just before 
we removed it.)
   
   I don't understand the point of waiting for the build to break before 
pinning or severely limiting the versions for libraries like these.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to