Github user chenghao-intel commented on a diff in the pull request:

    https://github.com/apache/spark/pull/4586#discussion_r25860341
  
    --- Diff: 
sql/hive/src/main/scala/org/apache/spark/sql/hive/test/TestHive.scala ---
    @@ -66,6 +66,10 @@ class TestHiveContext(sc: SparkContext) extends 
HiveContext(sc) {
       // without restarting the JVM.
       System.clearProperty("spark.hostPort")
       CommandProcessorFactory.clean(hiveconf)
    +  System.setProperty("hive.version", HiveShim.version)
    --- End diff --
    
    There is a SerDe jar at 
sql/hive/src/test/resources/data/files/TestSerDe.jar , Instead of whitelisting 
the `mapjoin_addjar` in `HiveCompatibilitySuite.scala`, we can create a new 
unit test in `HiveQuerySuite` for simplifying the unit testing. As setting the 
local maven repo like this seems a little bit hacky to me, it probably doesn't 
work if people modify the default location or the jar 
`hive-hcatalog-core-*.jar` doesn't exist in some cases.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to