Github user chenghao-intel commented on a diff in the pull request:
https://github.com/apache/spark/pull/4586#discussion_r25860457
--- Diff:
sql/hive/src/main/scala/org/apache/spark/sql/hive/execution/commands.scala ---
@@ -78,8 +82,23 @@ case class AddJar(path: String) extends RunnableCommand {
override def run(sqlContext: SQLContext) = {
val hiveContext = sqlContext.asInstanceOf[HiveContext]
hiveContext.runSqlHive(s"ADD JAR $path")
- hiveContext.sparkContext.addJar(path)
- Seq.empty[Row]
+ val substituted =
+ new
VariableSubstitution().substitute(sqlContext.asInstanceOf[HiveContext].hiveconf,
path)
+ hiveContext.sparkContext.addJar(substituted)
--- End diff --
As I remember, every SQL text is substitute in
https://github.com/apache/spark/blob/master/sql/hive/src/main/scala/org/apache/spark/sql/hive/HiveContext.scala#L86
Can you confirm if we really need a variable substitution here?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
