Github user nchammas commented on a diff in the pull request:
https://github.com/apache/spark/pull/4916#discussion_r25999086
--- Diff: ec2/spark_ec2.py ---
@@ -1259,6 +1259,15 @@ def real_main():
cluster_instances=(master_nodes + slave_nodes),
cluster_state='ssh-ready'
)
+
+ # Determine types of running instances
+ existing_master_type = master_nodes[0].instance_type
--- End diff --
Per my comments earlier, this change does not remove existing
functionality. It is currently not possible to change instance types when
starting a stopped cluster.
2015ë
3ì 7ì¼ (í ) ì¤í 12:08, Theodore Vasiloudis
<[email protected]>ëì´
ìì±:
> In ec2/spark_ec2.py
> <https://github.com/apache/spark/pull/4916#discussion_r25997522>:
>
> > @@ -1259,6 +1259,15 @@ def real_main():
> > cluster_instances=(master_nodes + slave_nodes),
> > cluster_state='ssh-ready'
> > )
> > +
> > + # Determine types of running instances
> > + existing_master_type = master_nodes[0].instance_type
>
> Yup, this is handled in get_existing_cluster
>
<https://github.com/thvasilo/spark/blob/SPARK-6188%5D-Instance-types-can-be-mislabeled-when-re-starting-cluster-with-default-arguments/ec2/spark_ec2.py#L617>
>
> â
> Reply to this email directly or view it on GitHub
> <https://github.com/apache/spark/pull/4916/files#r25997522>.
>
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
