Github user shivaram commented on a diff in the pull request:
https://github.com/apache/spark/pull/4916#discussion_r26010428
--- Diff: ec2/spark_ec2.py ---
@@ -1259,6 +1259,15 @@ def real_main():
cluster_instances=(master_nodes + slave_nodes),
cluster_state='ssh-ready'
)
+
+ # Determine types of running instances
+ existing_master_type = master_nodes[0].instance_type
+ existing_slave_type = slave_nodes[0].instance_type
+ if existing_master_type == existing_slave_type:
--- End diff --
Good point -- but the problem of `master_instance_type` differing from the
slaves and handling the configs cleanly is outside the scope of this PR.
Anyways I'm fine with setting it to `""` or not -- one thing you could do
is add a comment saying why we do it as it seems unintuitive.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
