dongjoon-hyun commented on a change in pull request #28090: [SPARK-31321][SQL]
Remove SaveMode check in v2 FileWriteBuilder
URL: https://github.com/apache/spark/pull/28090#discussion_r401897391
##########
File path:
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/v2/FileWriteBuilder.scala
##########
@@ -46,12 +45,6 @@ abstract class FileWriteBuilder(
private val schema = info.schema()
private val queryId = info.queryId()
private val options = info.options()
- private var mode: SaveMode = _
-
- def mode(mode: SaveMode): WriteBuilder = {
Review comment:
@yaooqinn . Technically, removal of dead code is not a bug fix. Please
re-category this as an `Improvement`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
